[libcxx-commits] [libcxx] 1685037 - Revert "[libc++] Enable the new libc++ testing format by default"

David Zarzycki via libcxx-commits libcxx-commits at lists.llvm.org
Sun Apr 5 04:17:29 PDT 2020


Author: David Zarzycki
Date: 2020-04-05T07:16:47-04:00
New Revision: 168503773dc216a7805f52d2868c1a1504297adc

URL: https://github.com/llvm/llvm-project/commit/168503773dc216a7805f52d2868c1a1504297adc
DIFF: https://github.com/llvm/llvm-project/commit/168503773dc216a7805f52d2868c1a1504297adc.diff

LOG: Revert "[libc++] Enable the new libc++ testing format by default"

This reverts commit 1580c76c4a08e24adc34ae0a4ff4f97969188268.

This causes libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp to
fail with a linker error on Fedora 31 (x86-64) release (no assert)
builds.

Added: 
    

Modified: 
    libcxx/test/lit.cfg

Removed: 
    


################################################################################
diff  --git a/libcxx/test/lit.cfg b/libcxx/test/lit.cfg
index 86e806067a5b..8f42dd7c468b 100644
--- a/libcxx/test/lit.cfg
+++ b/libcxx/test/lit.cfg
@@ -52,9 +52,9 @@ config_module = __import__(config_module_name, fromlist=['Configuration'])
 configuration = config_module.Configuration(lit_config, config)
 configuration.configure()
 configuration.print_config_info()
-if lit_config.params.get('use_old_format', False):
-    lit_config.note("Using the old libc++ testing format")
-    config.test_format = configuration.get_test_format()
-else:
+if lit_config.params.get('use_new_format', False):
+    lit_config.note("Using the experimental libc++ testing format")
     import libcxx.test.newformat
     config.test_format = libcxx.test.newformat.CxxStandardLibraryTest()
+else:
+    config.test_format = configuration.get_test_format()


        


More information about the libcxx-commits mailing list