[libcxx-commits] [PATCH] D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC

Raul Tambre via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Apr 3 12:28:24 PDT 2020


tambre added a comment.

In D77370#1960387 <https://reviews.llvm.org/D77370#1960387>, @compnerd wrote:

> I think that this really was an oversight, and that we should default to PIC builds, at least for shared libraries.


Would two flags `LIBUNWIND_ENABLE_SHARED_PIC` and `LIBUNWIND_ENABLE_STATIC_PIC` sound good to you? Then we could default shared to `ON`, but static to `OFF`.
Enabling PIC in static builds is something I need.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77370/new/

https://reviews.llvm.org/D77370





More information about the libcxx-commits mailing list