[libcxx-commits] [PATCH] D77338: [libc++] Add an alternative Lit test format

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

This is mostly a heads-up review. I welcome comments and improvement suggestions. This patch is a no-op unless one opts into the new format, and in particular this doesn't change the interaction between CMake and `config.py` at all. Because of this, I will not hold off committing this in order to start adopting it more widely right away -- improvements can be made as follow-up patches as I get more feedback from people who try it out.

I have been tweaking the libc++ test suite in the past couple of weeks in order to make this format and the current format essentially equivalent. As of right now, this format allows me to run all tests locally or remotely on both macOS and our CI Docker images (including filesystem tests, which doesn't work with the old format). I especially welcome feedback from people who try it out on Windows or on configurations I'm not aware of.

The only known "problem" with the new format is that the `test/libcxx/type_traits/is_pointer.arc.pass.mm` test doesn't pass right now. This is actually rather troubling -- the old format is broken and skips `.pass.mm` tests entirely, so that test simply was never executed since I added it one year ago.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77338/new/

https://reviews.llvm.org/D77338