[libcxx-commits] [PATCH] D77099: Exit unwinding early when at the top of the stack and additional info won't be found.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D77099#1957662 <https://reviews.llvm.org/D77099#1957662>, @mstorsjo wrote:

> In D77099#1957168 <https://reviews.llvm.org/D77099#1957168>, @ldionne wrote:
>
> > Is @mstorsjo, @phosek and @compnerd a suitable set of members? I'll coordinate with @benhamilton to create it (he's the Phabricator magician).
>
>
> I'm not comfortable reviewing/approving everything in libunwind, but I've spent some time debugging it at least, so I can at least review things that touch some bits, and the windows aspect.


A review group has been setup now, so at least one person of the group needs to LGTM a patch before it can be merged. It doesn't have to be you when you're not comfortable, but the idea is to give a notion of who the code owners (or at least knowledgeable people) are. Otherwise, there's always a question of is X's review sufficient or not? Who else should I ask? Creating a review group makes that easier. Also, the group allows self-add/remove, so it can adjust itself organically.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77099/new/

https://reviews.llvm.org/D77099