[libcxx-commits] [PATCH] D77140: [libc++] Reimplement the dynamic filesystem helper without using Python

Thu Apr 2 10:17:36 PDT 2020

ldionne added a comment.

In D77140#1957510 <https://reviews.llvm.org/D77140#1957510>, @arichardson wrote:

> Thank you very much for working in this @ldionne ! We (the CHERI project, https://github.com/CTSRD-CHERI/llvm-project/) can only sensibly test libc++ using the SSH executor since we use FPGA and QEMU implementations of CHERI MIPS/RISCV. 
>  So far I completely skipped the filesystem tests since our minimal test images don't contain python and I'm looking forward to being able to also run those tests.

My pleasure! I'm glad this is useful to others too. We're not always aware of all the different ways the test suite is used, but I keep being impressed.

> I am currently in the process of merging from upstream LLVM and I will attempt to upstream my libc++ lit changes once I've completed that.
>  I've made a few changes to libc++'s lit remote SSH execution (e.g. adding a new SSHExecutor running with a NFS/SMBFS mounted directory to avoid the scp overhead) that might also be useful upstream.

Interesting -- please note that significant changes are coming to how we configure the libc++ test suite. Specifically, I want to decouple it from the CMake configuration so that we can start checking-in Lit configurations in the repository. It might appear a bit hand-wavy right now, however it should become clearer soon. Feel free to reach out to me on the Cpplang Slack at @ldionne if you want to chat about it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77140/new/

https://reviews.llvm.org/D77140