[libcxx-commits] [libcxx] r372963 - [libcxx] Do not implicitly #include assert.h

Eric Fiselier via libcxx-commits libcxx-commits at lists.llvm.org
Thu Sep 26 09:31:03 PDT 2019


The standard library is free to transitively include other headers.
removing these transitive includes will break people. why was this change
necessary?



On Thu, Sep 26, 2019, 9:14 AM Marshall Clow <mclow.lists at gmail.com> wrote:

>
>
> On Thu, Sep 26, 2019 at 6:08 AM David Zarzycki via libcxx-commits <
> libcxx-commits at lists.llvm.org> wrote:
>
>> Author: davezarzycki
>> Date: Thu Sep 26 04:12:29 2019
>> New Revision: 372963
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=372963&view=rev
>> Log:
>> [libcxx] Do not implicitly #include assert.h
>>
>> Users should only get the assert() macros if they explicitly include
>> them.
>>
>
> David --
>
> I missed the Phabricator review of this change.
> Can you point me at it, please?
>
> -- Marshall (libc++ code owner)
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190926/f344f315/attachment.html>


More information about the libcxx-commits mailing list