[libcxx-commits] [PATCH] D67052: Add reference type transformation builtins
Zoe Carver via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Sep 19 18:59:10 PDT 2019
zoecarver marked 5 inline comments as done.
zoecarver added inline comments.
Comment at: clang/lib/Sema/SemaType.cpp:1612
+ case DeclSpec::TST_addLValueReferenceType:
+ case DeclSpec::TST_addRValueReferenceType:
> This should be merged with the above case.
The reason I haven't done that is because `__underlying_type` will default to `IntTy` if it fails. We don't want that for the others (maybe we don't want that here either?).
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits