[libcxx-commits] [PATCH] D66178: Remove std::shared_ptr::make_shared and std::shared_ptr::allocate_shared

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Sep 17 09:19:38 PDT 2019


ldionne added a comment.

In order to make progress on this, we could split this patch. I suggest roughly three patches:

1. Remove the faux-variadics for C++03 but still use the static member functions
2. Remove `std::shared_ptr<T>::allocate_shared`
3. Remove `std::shared_ptr<T>::make_shared` (I suspect this is what triggers the segfault).

By doing it in steps, we should be able to make some progress, and when we hit the segfault again, it might be clearer what the problem is.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66178/new/

https://reviews.llvm.org/D66178





More information about the libcxx-commits mailing list