[libcxx-commits] [PATCH] D62451: Regex backreference [1/3] Fixes backreferences for extended grammar.
Marshall Clow via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Sep 11 09:34:57 PDT 2019
mclow.lists added a comment.
I'm not a big fan of duplicated code; but especially in this case, since in D62453 <https://reviews.llvm.org/D62453> you edit the duplicated code to add a `throw`; but you have to do it twice - once in `__parse_backref` and once in the new code. Why is that preferable?
CHANGES SINCE LAST ACTION
More information about the libcxx-commits