[libcxx-commits] [PATCH] D62228: Make `vector` unconditionally move elements when exceptions are disabled.
Jordan Rupprecht via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Sep 5 15:18:22 PDT 2019
rupprecht added a comment.
In D62228#1659300 <https://reviews.llvm.org/D62228#1659300>, @ldionne wrote:
> In D62228#1658620 <https://reviews.llvm.org/D62228#1658620>, @rupprecht wrote:
> > It looks like this breaks uses of `std::vector` with classes that are copy only (moves disabled): https://godbolt.org/z/ct2GIe
> > gcc/libstdc++ or clang/libc++ w/ exceptions enabled both support it.
> > Is this breakage intentional?
> I don't think this was intentional, and I think your example should be valid. I added the test you provided to the test suite in https://reviews.llvm.org/rCXX371067, and I temporarily reverted this commit in https://reviews.llvm.org/rCXX371068. We can take a look once @EricWF is back from vacation.
Thanks for the revert!
CHANGES SINCE LAST ACTION
More information about the libcxx-commits