[libcxx-commits] [PATCH] D66614: Add inline to uflow and underflow
Aditya Kumar via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Sep 4 16:38:17 PDT 2019
hiraditya added a comment.
In D66614#1657962 <https://reviews.llvm.org/D66614#1657962>, @ldionne wrote:
> Normally, `inline` is used to control the linkage of a function, so that it is ODR-deduplicated across TUs. Correctness of the program is the only thing it should be used for, if we rely on what optimizer folks tell us (e.g. in conferences).
inline hint is used to determine inlining threshold, so it does have effect on llvm's inlining decision. e.g., https://github.com/llvm-mirror/llvm/blob/master/lib/Analysis/InlineCost.cpp#L917
> For that reason, my first reaction would be to consider this failed optimization an optimizer bug, not a library bug.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits