[libcxx-commits] [PATCH] D69170: [libcxx] [test] Run `chmod +x` on executables when testing via SSH

[Sergej Jaskiewicz via Phabricator via libcxx-commits]

broadwaylamb marked an inline comment as done.
broadwaylamb added inline comments.


================
Comment at: libcxx/utils/libcxx/test/executor.py:170
             # returned here:
-            return self._execute_command_remote(cmd, target_cwd, env)
+            return self._execute_command_remote(chmod_cmd + ['&&'] + cmd,
+                                                target_cwd,
----------------
Found a bug in this line: in the `_execute_command_remote` method we actually prepend the `env` command to set the execution environment. However, because of this patch, the `env` command is only applied to chmod.

I'm going to send a fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69170/new/

https://reviews.llvm.org/D69170