[libcxx-commits] [PATCH] D68952: Guard against possible overflow in span.subpan

[Shoaib Meenai via Phabricator via libcxx-commits]

smeenai added a comment.

In D68952#1718235 <https://reviews.llvm.org/D68952#1718235>, @CaseyCarter wrote:

> (I'm not sure how to withdraw my "Request Changes" without approving - I'm not an authorized approver for libc++ - so I'll "Resign as Reviewer" and see if my red X goes away.)


Phabricator clears a request changes status when you upload a new version, so in this case you didn't need to do anything. In the general case though, I've found that the only way to clear an active request changes is to approve and then resign as reviewer. Resigning as reviewer clears your approval, but doesn't clear a request changes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68952/new/

https://reviews.llvm.org/D68952