[libcxx-commits] [PATCH] D68275: [libcxx] [test] Query the target platform, not the host one

[Sergej Jaskiewicz via Phabricator via libcxx-commits]

broadwaylamb marked 3 inline comments as done.
broadwaylamb added inline comments.


================
Comment at: libcxx/utils/libcxx/test/config.py:73
         self.debug_build = self.get_lit_bool('debug_build',   default=False)
-        self.exec_env = dict(os.environ)
+        self.exec_env = dict()
         self.use_target = False
----------------
We're now looking at the host environemnt in the `_merge_environments` method of an `Executor` object (see `executor.py`). Only the local executor calls `os.environ`.


================
Comment at: libcxx/utils/libcxx/test/config.py:204
+
+        te.target_info = self.target_info
+        
----------------
An executor object now knows more about its target, and can make proper adjustments based on it.


================
Comment at: libcxx/utils/libcxx/test/executor.py:146
             target_cwd = self.remote_temp_dir()
-            target_exe_path = os.path.join(target_cwd, 'libcxx_test.exe')
+            target_exe_path = str(PurePosixPath(target_cwd) / 'libcxx_test.exe')
             if cmd:
----------------
This is so that the path separators are handled correctly when we're connecting from Windows to Unix


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68275/new/

https://reviews.llvm.org/D68275