[libcxx-commits] [PATCH] D68480: Implementation of C++20's P1135R6 for libcxx

[Michał Dominiak via Phabricator via libcxx-commits]

griwes added inline comments.


================
Comment at: libcxx/include/semaphore:67
+
+template<ptrdiff_t least_max_value>
+class __atomic_semaphore_base 
----------------
Use a reserved identifier for the template parameter.


================
Comment at: libcxx/include/semaphore:409
+
+template<ptrdiff_t least_max_value>
+using __semaphore_base = 
----------------
Use a reserved identifier for the template parameter.


================
Comment at: libcxx/include/semaphore:420
+
+template<ptrdiff_t least_max_value = INT_MAX>
+class counting_semaphore : public __semaphore_base<least_max_value> 
----------------
Use a reserved identifier for the template parameter.


================
Comment at: libcxx/test/std/thread/thread.barrier/arrive.pass.cpp:19
+{
+  std::barrier b(2);
+  
----------------
This depends on CTAD, which makes it only work in C++17 and above. Instead it should probably say `std::barrier<> b;`.

Same comment for all the other barrier and semaphore tests.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68480/new/

https://reviews.llvm.org/D68480