[libcxx-commits] [libcxx] r374854 - [libc++][test] Use <version> to get config on MSVC

Casey Carter via libcxx-commits libcxx-commits at lists.llvm.org
Mon Oct 14 17:22:38 PDT 2019


Author: caseycarter
Date: Mon Oct 14 17:22:38 2019
New Revision: 374854

URL: http://llvm.org/viewvc/llvm-project?rev=374854&view=rev
Log:
[libc++][test] Use <version> to get config on MSVC

...instead of `<ciso646>`.

Also includes some NFC comment changes.

Modified:
    libcxx/trunk/test/support/msvc_stdlib_force_include.h
    libcxx/trunk/test/support/test_macros.h
    libcxx/trunk/test/support/test_workarounds.h

Modified: libcxx/trunk/test/support/msvc_stdlib_force_include.h
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/support/msvc_stdlib_force_include.h?rev=374854&r1=374853&r2=374854&view=diff
==============================================================================
--- libcxx/trunk/test/support/msvc_stdlib_force_include.h (original)
+++ libcxx/trunk/test/support/msvc_stdlib_force_include.h Mon Oct 14 17:22:38 2019
@@ -77,7 +77,7 @@ const AssertionDialogAvoider assertion_d
     #define _SILENCE_ALL_CXX20_DEPRECATION_WARNINGS
 #endif // _LIBCXX_IN_DEVCRT
 
-#include <ciso646>
+#include <version>
 
 #if _HAS_CXX20
     #define TEST_STD_VER 99

Modified: libcxx/trunk/test/support/test_macros.h
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/support/test_macros.h?rev=374854&r1=374853&r2=374854&view=diff
==============================================================================
--- libcxx/trunk/test/support/test_macros.h (original)
+++ libcxx/trunk/test/support/test_macros.h Mon Oct 14 17:22:38 2019
@@ -140,7 +140,7 @@
 #define TEST_THROW_SPEC(...) throw(__VA_ARGS__)
 #endif
 
-// Sniff out to see if the underling C library has C11 features
+// Sniff out to see if the underlying C library has C11 features
 // Note that at this time (July 2018), MacOS X and iOS do NOT.
 // This is cribbed from __config; but lives here as well because we can't assume libc++
 #if __ISO_C_VISIBLE >= 2011 || TEST_STD_VER >= 11

Modified: libcxx/trunk/test/support/test_workarounds.h
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/support/test_workarounds.h?rev=374854&r1=374853&r2=374854&view=diff
==============================================================================
--- libcxx/trunk/test/support/test_workarounds.h (original)
+++ libcxx/trunk/test/support/test_workarounds.h Mon Oct 14 17:22:38 2019
@@ -13,19 +13,19 @@
 #include "test_macros.h"
 
 #if defined(TEST_COMPILER_EDG)
-# define TEST_WORKAROUND_EDG_EXPLICIT_CONSTEXPR // VSO#424280
+# define TEST_WORKAROUND_EDG_EXPLICIT_CONSTEXPR // VSO-424280
 #endif
 
 #if defined(TEST_COMPILER_C1XX)
-# define TEST_WORKAROUND_C1XX_BROKEN_IS_TRIVIALLY_COPYABLE // VSO#117743
+# define TEST_WORKAROUND_C1XX_BROKEN_IS_TRIVIALLY_COPYABLE // VSO-117743
 # ifndef _MSC_EXTENSIONS
-#  define TEST_WORKAROUND_C1XX_BROKEN_ZA_CTOR_CHECK // VSO#119998
+#  define TEST_WORKAROUND_C1XX_BROKEN_ZA_CTOR_CHECK // VSO-119998
 # endif
 #endif
 
 #if defined(TEST_COMPILER_GCC)
 # if __GNUC__ < 9
-#  define TEST_WORKAROUND_CONSTEXPR_IMPLIES_NOEXCEPT // GCC PR 87603
+#  define TEST_WORKAROUND_CONSTEXPR_IMPLIES_NOEXCEPT // GCC-87603
 # endif
 #endif
 




More information about the libcxx-commits mailing list