[libcxx-commits] [libcxx] r374722 - [libc++][test] <=> now has a feature-test macro

Casey Carter via libcxx-commits libcxx-commits at lists.llvm.org
Sun Oct 13 09:46:12 PDT 2019


Author: caseycarter
Date: Sun Oct 13 09:46:12 2019
New Revision: 374722

URL: http://llvm.org/viewvc/llvm-project?rev=374722&view=rev
Log:
[libc++][test] <=> now has a feature-test macro

...which `test/support/test_macros.h` can use to detect compiler support.

Modified:
    libcxx/trunk/test/support/test_macros.h

Modified: libcxx/trunk/test/support/test_macros.h
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/support/test_macros.h?rev=374722&r1=374721&r2=374722&view=diff
==============================================================================
--- libcxx/trunk/test/support/test_macros.h (original)
+++ libcxx/trunk/test/support/test_macros.h Sun Oct 13 09:46:12 2019
@@ -223,9 +223,8 @@
 #define TEST_SAFE_STATIC
 #endif
 
-// FIXME: Fix this feature check when either (A) a compiler provides a complete
-// implementation, or (b) a feature check macro is specified
-#if !defined(_MSC_VER) || defined(__clang__) || _MSC_VER < 1920 || _MSVC_LANG <= 201703L
+#if !defined(__cpp_impl_three_way_comparison) \
+    && (!defined(_MSC_VER) || defined(__clang__) || _MSC_VER < 1920 || _MSVC_LANG <= 201703L)
 #define TEST_HAS_NO_SPACESHIP_OPERATOR
 #endif
 




More information about the libcxx-commits mailing list