[libcxx-commits] [PATCH] D68623: Optimize and fix basic_string move assignment operator

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 10 20:43:50 PDT 2019


mclow.lists added a comment.

This looks ok to me.  If you're concerned about performance, you might want to split this into two routines, one for the case were the allocators are equal, and one for the case where they're not (and skip the whole allocator dance for the equal case.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68623/new/

https://reviews.llvm.org/D68623





More information about the libcxx-commits mailing list