[libcxx-commits] [PATCH] D68075: Do not #error if no OS is #defined

Fri Oct 4 22:03:39 PDT 2019

EricWF added a comment.

threading support is required to implement a conforming standard library. if we don't have it we're non-conforming.

additionally this option changes the symbols we export from the dylib. a library built without threads is not compatible with usages that have threads and vice versa

when we build the library either we configure with threading disabled, or threads are enabled and it should be a hard error if that configuration is broken.

The test failures you're running into are correctly failing and should not be made to pass. making them password hide a bug. The compeler's test suite is not a normal consumer of the standard library, and we shouldn't bend to it as such.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68075/new/

https://reviews.llvm.org/D68075