[libcxx-commits] [PATCH] D68276: # Enter a commit message. # # Changes: # # libcxx/include/string

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 1 08:26:47 PDT 2019


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

The change looks good to me, even though I'm a bit surprised the compiler can't figure it out itself. The benchmarks in https://reviews.llvm.org/D67667 are certainly a plus, but I don't think they should block this revision.

Please make sure you fix your commit message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68276/new/

https://reviews.llvm.org/D68276





More information about the libcxx-commits mailing list