[libcxx-commits] [PATCH] D70815: Enable `-funwind-tables` flag when building libunwind

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 28 14:31:25 PST 2019


phosek added inline comments.


================
Comment at: libunwind/CMakeLists.txt:236
+# libunwind quite useless in this setup.
+set(CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY)
+
----------------
This option is only available since CMake 3.6, but the minimum requirement for LLVM is 3.4. There's a separate discussion on llvm-dev about bumping that version, but until that happens, this should be behind a condition to avoid breaking users and bots that use CMake 3.4 and 3.5.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70815/new/

https://reviews.llvm.org/D70815





More information about the libcxx-commits mailing list