[libcxx-commits] [PATCH] D70815: Enable `-funwind-tables` flag when building libunwind

[Peter Smith via Phabricator via libcxx-commits]

peter.smith added a comment.

I've put some comments inline. I'm no CMake expert though, so there may be other reviewers that can make alternative suggestions.



================
Comment at: libunwind/CMakeLists.txt:311
+
+if (LIBUNWIND_USES_ARM_EHABI AND NOT LIBUNWIND_SUPPORTS_FUNWIND_TABLES_FLAG)
+  message(FATAL_ERROR "The -funwind-tables flag must be supported "
----------------
Assuming we can't set CMAKE_TRY_COMPILE_TARGET_TYPE is to do something like:
```
if (LIBUNWIND_USES_ARM_EHABI)
  // unconditionally add -funwind-tables
```
Anyone trying to compile libunwind without a compiler that supports -funwind-tables gets an error message at build rather than configure time, but is there anyone that wouldn't use a form of Clang or GCC?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70815/new/

https://reviews.llvm.org/D70815