[libcxx-commits] [PATCH] D70397: [libunwind] Adjust the signal_frame test for Arm

[Steven Wu via Phabricator via libcxx-commits]

steven_wu added a comment.

In D70397#1753789 <https://reviews.llvm.org/D70397#1753789>, @miyuki wrote:

> In D70397#1753767 <https://reviews.llvm.org/D70397#1753767>, @steven_wu wrote:
>
> > In this patch, add another stack frame completely defeat the purpose of `assert(unw_step(&cursor) > 0);`.
>
>
> Is the DWARF unwinder supposed to be always able to step out of main()?


I don't know signal frame but I think the purpose of that assert is to check unw_step return value > 0 from main if that is a signal frame. Adding another frame will make that assert always be true, regardless of signal frame, thus it is not testing signal frame anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70397/new/

https://reviews.llvm.org/D70397