[libcxx-commits] [PATCH] D70397: [libunwind] Adjust the signal_frame test for Arm

[Steven Wu via Phabricator via libcxx-commits]

steven_wu added a comment.

In D70397#1753428 <https://reviews.llvm.org/D70397#1753428>, @broadwaylamb wrote:

> This test won't compile for ARM Linux (using ARM EHABI), I get the error `this directive must appear between .cfi_startproc and .cfi_endproc directives`.


Can you post the compile commands used by the test? `.cfi_startproc` and `.cfi_endproc` should be there for most platforms if the test is built with -funwind-table.

> Adding those directives fixes the error (and the test successfully passes), but I'm not a libunwind expert and not sure whether it's ok. Do you think explicitly adding those directives is appropriate? Does it even make sense to run this test with ARM EHABI enabled?

I think this is not the correct fix. We should probably disable this test for ARM EHABI and APPLE (which uses compact unwind) that doesn't use DWARF unwind. In this patch, add another stack frame completely defeat the purpose of `assert(unw_step(&cursor) > 0);`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70397/new/

https://reviews.llvm.org/D70397