[libcxx-commits] [PATCH] D68480: Implementation of C++20's P1135R6 for libcxx

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

> - _LIBCPP_HAS_NO_PLATFORM_WAIT
> - _LIBCPP_HAS_NO_PLATFORM_WAIT_TABLE
> - _LIBCPP_HAS_NO_PLATFORM_WAIT_STATE

It would be great to document these macros somewhere in the code or in a `.rst` document.

Also, this paper didn't add any feature-test macro?



================
Comment at: libcxx/include/atomic:1850
     typedef __atomic_base<_Tp> __base;
+    using value_type = _Tp;
     _LIBCPP_INLINE_VISIBILITY
----------------
Can we add a test for this?


================
Comment at: libcxx/include/atomic:1871
     typedef __atomic_base<_Tp*> __base;
+    using value_type = _Tp*;
     _LIBCPP_INLINE_VISIBILITY
----------------
This too!


================
Comment at: libcxx/include/chrono:1571
 
+#ifndef _LIBCPP_HAS_CLOCK_API_EXTERNAL
+
----------------
What's that?


================
Comment at: libcxx/include/semaphore:77
+
+__atomic_semaphore_base is the general-case implementation, to be used for
+user-requested least-max values that exceed the OS implementation support
----------------
Thanks for the comments in this file, I wish we did that more often.


================
Comment at: libcxx/include/type_traits:4032
+#ifdef _LIBCPP_BEGIN_NAMESPACE_STD_NOVERSION
+_LIBCPP_BEGIN_NAMESPACE_STD_NOVERSION
+#else
----------------
What are these drive-by fixes?


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68480/new/

https://reviews.llvm.org/D68480