[libcxx-commits] [PATCH] D69505: [libcxx] [Windows] Store the lconv struct returned from localeconv in locale_t

Reid Kleckner via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Nov 17 09:14:38 PST 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

I don't have any great ideas, honestly. It seems like if we want to make non-default locales work well with libc++ on Windows, we're going to have to do more work to reimplement locales or find some new entry points in ucrtbase.dll that take the locale as a parameter instead of as a global.

In the meantime, this seems fine as stopgap fix.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69505/new/

https://reviews.llvm.org/D69505





More information about the libcxx-commits mailing list