[libcxx-commits] [PATCH] D69983: [libcxx] Omit unneeded locale fallbacks on Android 21+

Elliott Hughes via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 7 21:30:57 PST 2019


enh added a comment.

honestly, if it was me, i'd keep all these inlines even for current releases: inlining a call to the underlying function saves you a layer of useless cruft at runtime. (the Android "implementations" are just one-liners that drop the extra argument and call the underlying function, just like these inlines.)

if Android were the only system making use of this and you could otherwise remove it, that would be different, but since you need it for other configurations anyway...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69983/new/

https://reviews.llvm.org/D69983





More information about the libcxx-commits mailing list