[libcxx-commits] [PATCH] D69554: [libcxx] [Windows] Make a more proper implementation of strftime_l for mingw with msvcrt.dll

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Nov 2 11:43:45 PDT 2019


mclow.lists added a comment.

This looks reasonable to me, but I noticed that there's a behavior difference - `__libcpp_locale_guard` has been added. (previously the `loc` parameter was ignored).

Shouldn't there be a test for this new behavior?


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69554/new/

https://reviews.llvm.org/D69554





More information about the libcxx-commits mailing list