[libcxx-commits] [PATCH] D62233: General shared_ptr cleanup

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked an inline comment as done.
zoecarver added inline comments.


================
Comment at: include/memory:4008
+        } catch (...) {
+            __d(__p);
+            throw;
----------------
EricWF wrote:
> You're deleting a `nullptr` here. IDK if that makes sense.
If it matters, I can change it, but I don't think it should. If, for example, a `shared_ptr` to a `nullptr` went out of scope, the same thing would happen, so people's deleters should be able to handle this (especially if they are ever passing it a `nullptr`). 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62233/new/

https://reviews.llvm.org/D62233