[libcxx-commits] [PATCH] D62641: Support arrays in make_shared and allocate_shared (P0674R1)

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu May 30 20:26:58 PDT 2019


zoecarver marked an inline comment as done.
zoecarver added inline comments.


================
Comment at: include/memory:4686
+    _CntrlBlk* __cntrl_ptr = reinterpret_cast<_CntrlBlk*>(__arr_block->__cntrl_buff);
+    _ET* __arr_ptr = reinterpret_cast<_ET*>(__arr_block->__value_buff);
+
----------------
This might create problems with scary pointers. Pointer traits should be used. 


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62641/new/

https://reviews.llvm.org/D62641





More information about the libcxx-commits mailing list