[libcxx-commits] [PATCH] D62618: [libcxx] Make std::tuple<> trivially constructible

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added a comment.

Changing the triviality of a type can be ABI breaking because it will change the calling conventions the compiler uses.
We have hacks in pair to keep it non-trivial on some platforms for this reason.

I'm not sure if this case triggers that change (it may only be when you change `is_trivially_copyable`). But we need to double check.



================
Comment at: libcxx/include/tuple:910
     _LIBCPP_INLINE_VISIBILITY
-    _LIBCPP_CONSTEXPR tuple() _NOEXCEPT {}
+    _LIBCPP_CONSTEXPR tuple() _NOEXCEPT _LIBCPP_DEFAULT
     template <class _Alloc>
----------------
This is C++11 and up so you can just write `= default`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62618/new/

https://reviews.llvm.org/D62618