[libcxx-commits] [PATCH] D62090: [runtimes] Support ELF dependent libraries feature

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 29 11:47:10 PDT 2019


phosek added a comment.

In D62090#1521187 <https://reviews.llvm.org/D62090#1521187>, @ldionne wrote:

> It's not entirely clear to me that adding an option to control this is better than just doing it unconditionally. Have you run into a scenario where you didn't want to enable it (and if so, why?).
>
> If that's "just in case", I'd suggest doing it unconditionally and adding an option later if a vendor wants to disable it.


That makes sense, I've removed the option but I've moved the pragma from headers into source files to avoid it being injected into users code through includes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62090/new/

https://reviews.llvm.org/D62090





More information about the libcxx-commits mailing list