[libcxx-commits] [PATCH] D62566: [libcxx][libcxxabi] Remove the unused CMake checks

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

Alternative would be to avoid `add_compile_flags_if_supported` altogether and instead the combination of `check_cxx_compiler_flag` and `append_if` as is used in libunwind (https://github.com/llvm/llvm-project/blob/master/libunwind/CMakeLists.txt#L274). The advantage of the latter is that we could in theory have different `config-ix.cmake` files (e.g. pre-populated ones for the runtimes build).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62566/new/

https://reviews.llvm.org/D62566