[libcxx-commits] [PATCH] D62103: Update shared_ptr tests to match the standard

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added inline comments.


================
Comment at: test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/shared_ptr_Y_rv.pass.cpp:96
             assert(pA.get() == pB.get());
+            assert(pA.get() == nullptr);
         }
----------------
mclow.lists wrote:
> I would think that this test should go on line 87
The point is to assert both `pA` and `pB` point to `nullptr`. I can update. 


================
Comment at: test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/shared_ptr_pointer.pass.cpp:73
+
+#if TEST_STD_VER > 14
+    {
----------------
mclow.lists wrote:
> Again, why `14`?
This should be after `C++17`.  This is testing the second overload for rvalue references: http://eel.is/c++draft/util.smartptr.shared#const-15


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62103/new/

https://reviews.llvm.org/D62103