[libcxx-commits] [PATCH] D56498: [libcxx] Fix order checking in some more unordered_multimap tests.

[Andrey Maksimov via Phabricator via libcxx-commits]

amakc11 added inline comments.


================
Comment at: test/std/containers/check_consecutive.h:1
+//===----------------------------------------------------------------------===//
+//
----------------
EricWF wrote:
> Please put this in `test/support`, which is on the include paths for the tests. That way you don't have to include it via relative path.
First, my primary goal when making patches to tests is to be fully consistent with the original style of the original author of each test. In the tests in question, there is a lot of code like this:
```
#include "../../../test_compare.h"
#include "../../../test_hash.h"
```
My patch is consistent with it, isn't it?

Second, moving those headers (all of them, to be consistent) to another directory is a target for refactoring which might be a goal of another patch. Let's move step by step and not mix multiple tasks in one single patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56498/new/

https://reviews.llvm.org/D56498