[libcxx-commits] [PATCH] D62060: Make libc++'s libc++abi discovery work in the monorepo layout
Nico Weber via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri May 17 12:33:56 PDT 2019
thakis marked an inline comment as done.
thakis added inline comments.
================
Comment at: libcxx/CMakeLists.txt:153
+ (LLVM_ENABLE_PROJECTS_USED OR NOT LLVM_ENABLE_PROJECTS STREQUAL ""))
+ if ("libcxxabi" IN_LIST LLVM_ENABLE_PROJECTS)
+ set(LIBCXX_HAVE_LIBCXXABI_CHECKOUT_INTERNAL TRUE)
----------------
thakis wrote:
> smeenai wrote:
> > What about `LLVM_ENABLE_RUNTIMES`? I think this might break that ... CC @phosek
> What's the difference between LLVM_ENABLE_RUNTIMES and LLVM_ENABLE_PROJECTS? They seem redundant to me at first glance.
>
> But I suppose this should become `if ("libcxxabi" IN_LIST LLVM_ENABLE_PROJECTS OR "libcxxabi" IN_LIST LLVM_ENABLE_RUNTIMES)`?
To rephrase this, what does it mean to have something in LLVM_ENABLE_RUNTIMES but not in LLVM_ENABLE_PROJECTS?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62060/new/
https://reviews.llvm.org/D62060
More information about the libcxx-commits
mailing list