[libcxx-commits] [PATCH] D61954: Ensure that hash<basic_string> uses char_traits (41876)

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 15 14:13:58 PDT 2019


zoecarver marked 2 inline comments as done.
zoecarver added inline comments.


================
Comment at: test/std/strings/basic.string.hash/char_type_hash.fail.cpp:24
+    typedef int       int_type;
+    typedef streamoff off_type;
+    typedef streampos pos_type;
----------------
mclow.lists wrote:
> these may need `std::` qualifications
See line 17.


================
Comment at: test/std/strings/basic.string.hash/char_type_hash.fail.cpp:28
+
+    static inline void _LIBCPP_CONSTEXPR_AFTER_CXX14
+        assign(char_type& __c1, const char_type& __c2) _NOEXCEPT {__c1 = __c2;}
----------------
mclow.lists wrote:
> You should get rid of the `_LIBCPP_CONSTEXPR_AFTER_CXX14` and `_LIBCPP_CONSTEXPR` and `_LIBCPP_INLINE_VISIBILITY`  and `_NOEXCEPT` bits.
Will do. I was a bit lazy with copying this in :P 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61954/new/

https://reviews.llvm.org/D61954





More information about the libcxx-commits mailing list