[libcxx-commits] [PATCH] D61915: [libcxx] change dylib- XFAILs to UNSUPPORTED

Wed May 15 09:43:19 PDT 2019

bcain added a comment.

In D61915#1503179 <https://reviews.llvm.org/D61915#1503179>, @mclow.lists wrote:

> In D61915#1502132 <https://reviews.llvm.org/D61915#1502132>, @bcain wrote:
>
> >
>

...

> (I'm going to comment on just the `variant`/`optional`/ `any` tests here, because I think they're straightforward).
>  They're marked as XFAIL when the dylib doesn't have the appropriate exception classes - and they should fail.
>  They also should fail if they are built with exceptions disabled - because the exceptions will never get thrown. This behavior should be confirmed.

Fair enough.

So I took a minute to try and understand the XPASS and I think that the filesystem header installation isn't guarded by LIBCXX_ENABLE_FILESYSTEM -- only the sources.

Maybe the presence of the filesystem header is enough to get some of these tests to pass.  So maybe I should go ahead and change this patch to do that instead?

Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61915/new/

https://reviews.llvm.org/D61915