[libcxx-commits] [PATCH] D61878: Use is_permutation when comparing containers

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 14 13:26:17 PDT 2019


ldionne added a comment.

What I would like here instead of just a benchmark is a test that ensures that the new implementation is faster than the old one (with some fuzz of course). Is that something reasonable to ask for? @mclow.lists Do you agree this would be better? I'm concerned that we won't be looking at benchmark results and might not notice if the new algorithm is slower under some circumstances.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61878/new/

https://reviews.llvm.org/D61878





More information about the libcxx-commits mailing list