[libcxx-commits] [PATCH] D61878: Use is_permutation when comparing containers

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver updated this revision to Diff 199370.
zoecarver added a comment.

- add benchmark

Let me know if there is anything I should add to the benchmark (or if I should write it differently). Here is the output from my machine:

  ----------------------------------------------------------------
  Benchmark                     Time             CPU   Iterations
  ----------------------------------------------------------------
  initialize_data           0.000 ns        0.000 ns            0
  test_small_old           166805 ns       166343 ns         4356
  test_small_new            64089 ns        63915 ns        10408
  test_small_range_old     287885 ns       287437 ns         2648
  test_small_range_new      50265 ns        50077 ns        10000
  test_big_old           95000392 ns     94921500 ns            6
  test_big_new           75199528 ns     75144333 ns            9

Unfortunately nowhere near what I was getting with the other test, but I suspect this is more accurate, and there is a bit of improvement (especially for sets with limited ranges).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61878/new/

https://reviews.llvm.org/D61878

Files:
  benchmarks/unordered_set_comp.bench.cpp
  include/unordered_map
  include/unordered_set

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61878.199370.patch
Type: text/x-patch
Size: 14157 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190514/cf40aff9/attachment-0001.bin>