[libcxx-commits] [PATCH] D61771: Comparing Unordered Containers (P0809)

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri May 10 07:24:25 PDT 2019


mclow.lists added inline comments.


================
Comment at: include/unordered_map:1690
+        _EqRng __yeq = __y.equal_range(__i->first);
+        if (_VSTD::distance(__xeq.first, __xeq.second) !=
+                _VSTD::distance(__yeq.first, __yeq.second) ||
----------------
zoecarver wrote:
> I can add some tests for this. Wanted to make sure it is correct first.
I like this implementation. It's straightforward, easy to read, and looks correct.
I'm still working through the complexity, though.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61771/new/

https://reviews.llvm.org/D61771





More information about the libcxx-commits mailing list