[libcxx-commits] [PATCH] D61348: [libcxx] add debug-mode feature flag

Brian Cain via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 8 08:08:55 PDT 2019


bcain added a comment.

In D61348#1486428 <https://reviews.llvm.org/D61348#1486428>, @bcain wrote:

> Changed debug-mode feature to be deactivated when the `LIBCXX_TEST_HAVE_FORK` option is disabled.  This hopefully sidesteps the debate triggered by the previous revision.


I think this change makes sense and avoids the controversy.  But I suppose the 'debug-mode' feature label might be misleading.  Maybe it be better if I just changed it to 'has-fork'?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61348/new/

https://reviews.llvm.org/D61348





More information about the libcxx-commits mailing list