[libcxx-commits] [PATCH] D59999: Allow the compiler to optimize `string == "literal string"`.

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

This LGTM. Thanks for all your hard work on this Sam.

I verified the export lists don't change. I'll land this tomorrow morning once the inline comments have been addressed.



================
Comment at: libcxx/include/string:3887
+inline _LIBCPP_INLINE_VISIBILITY
+bool
+operator==(const char* __lhs,
----------------
Can we add a brief comment that mentions this specialization is here to provide better code gen?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59999/new/

https://reviews.llvm.org/D59999