[libcxx-commits] [PATCH] D61014: Implement std::midpoint for floating point types

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 7 09:04:50 PDT 2019


mclow.lists marked 2 inline comments as done.
mclow.lists added inline comments.


================
Comment at: libcxx/include/numeric:559
+template <typename _Tp>
+int __sign(_Tp __val) {
+    return (_Tp(0) < __val) - (__val < _Tp(0));
----------------
a_Tom wrote:
> Shouldn't this function be constexpr?
Yes, it should - and it is now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61014/new/

https://reviews.llvm.org/D61014





More information about the libcxx-commits mailing list