[libcxx-commits] [PATCH] D58879: Implement uses-allocator (P0591R4)

Sun May 5 19:26:00 PDT 2019

zoecarver marked 2 inline comments as done.
zoecarver added inline comments.

================
Comment at: include/experimental/memory_resource:203

+#if _LIBCPP_STD_VER > 17
+    template <class _Tp, class... _Args>
----------------
Please note: this **is not tested** (and probably needs further changes). Because of [[ https://bugs.llvm.org/show_bug.cgi?id=41760 | 41760 ]] (which I am starting to think is my fault and not an actual bug), I was unable to run many of the `polymorphic_allocator` tests and therefore could not ensure that this was correctly implemented. 

================
Comment at: include/tuple:1377
 _LIBCPP_NOEXCEPT_RETURN(
-    _Tp(_VSTD::get<_Idx>(_VSTD::forward<_Tuple>(__t))...)
+    _Tp(_VSTD::move(_VSTD::get<_Idx>(_VSTD::forward<_Tuple>(__t)))...)
 )
----------------
zoecarver wrote:
> I can submit a separate patch for this. 
Given that a fix for this goes against the standard, I am not sure what to do here. First, I am going to look into this more and make sure it is necessary. 

As a note, the change here is not my suggested fix. Please see D61293 for that.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58879/new/

https://reviews.llvm.org/D58879