[libcxx-commits] [PATCH] D57646: [libcxx] Specify unwind lib before other system libraries.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D57646#1490202 <https://reviews.llvm.org/D57646#1490202>, @tabloid.adroit wrote:

> In D57646#1490180 <https://reviews.llvm.org/D57646#1490180>, @ldionne wrote:
>
> > I'll admit that I find it very brittle that ordering matters. We can do this, however it would be better to find another solution that doesn't require depending on the ordering of `-l` parameters. I don't know what that would be, though.
>
>
> `install_name_tool -change` could adjust the order for executable as a post build action. If there are additional dependent libraries, then reorder logic need to be updated. I'm not sure it would be an improvement than just put more comments in the existing code since overriding libSystem.B.dylib is a rare case.


`innstall_name_tool` is only available on Darwin unless I'm mistaken, so I think it's better not to add something that only works on a specific platform. It's an interesting suggestion nonetheless.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57646/new/

https://reviews.llvm.org/D57646