[libcxx-commits] [PATCH] D58582: Implement P0433: deduction guides for <set>

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added a comment.

A couple of minor nits.  
Same comment about `__identify` as in the other review.  You need answer it in one place, only.



================
Comment at: test/std/containers/associative/multiset/multiset.cons/deduct.pass.cpp:88
+    std::multiset<long> source;
+    std::multiset s{ source };
+    ASSERT_SAME_TYPE(decltype(s), std::multiset<long>);
----------------
A comment here "braces instead of paren" would be nice.


================
Comment at: test/std/containers/associative/multiset/multiset.cons/deduct.pass.cpp:104
+    ASSERT_SAME_TYPE(decltype(s), std::multiset<int>);
+    int expected_s[] = { 1, 1, 2, 3, INT_MAX };
+    assert(std::equal(s.begin(), s.end(), std::begin(expected_s),
----------------
These should all be `const`


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58582/new/

https://reviews.llvm.org/D58582