[libcxx-commits] [PATCH] D60422: Remove default parameters (P0935R0)

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 1 20:24:06 PDT 2019


zoecarver marked 2 inline comments as done.
zoecarver added inline comments.


================
Comment at: include/queue:229
-    queue()
-        _NOEXCEPT_(is_nothrow_default_constructible<container_type>::value)
-        : c() {}
----------------
I didn't see this in the standard, but I can keep it.


================
Comment at: test/std/containers/container.adaptors/queue/queue.defn/default_constructor.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
Before I spend a lot of time writing tests for this, I want to check that I am writing the correct tests. I am going to use this test as a "template" for other tests. @EricWF how does this look? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60422/new/

https://reviews.llvm.org/D60422





More information about the libcxx-commits mailing list