[libcxx-commits] [PATCH] D60005: [libc++abi] Don't set POSITION_INDEPENDENT_CODE when building static library
Sam Clegg via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Mar 31 12:35:37 PDT 2019
sbc100 added a comment.
In D60005#1448955 <https://reviews.llvm.org/D60005#1448955>, @jiangyi wrote:
> After this patch, libcxx failed to compile when -DLLVM_ENABLE_PIC=OFF and -DLIBCXX_ENABLE_STATIC_ABI_LIBRARY=ON.
> Maybe we should add an option to set PIC of libcxxabi. Something like
> option(LIBCXXABI_ENABLE_PIC "Build Position-Independent Code, which is required if LIBCXX_ENABLE_STATIC_ABI_LIBRARY is set in libcxx" ON)
> and add some checks in libcxx CMakeLists.txt to fail in cmake configure step if condition does not meet.
That sounds like a reasonable approach: https://reviews.llvm.org/D60049
CHANGES SINCE LAST ACTION
More information about the libcxx-commits