[libcxx-commits] [PATCH] D59099: Integer and pointer types of 'midpoint' from P0811

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Mar 30 12:15:48 PDT 2019


zoecarver added inline comments.


================
Comment at: libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.fail.cpp:19
+
+#include "test_macros.h"
+
----------------
Is this necessary? 


================
Comment at: libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.integer.pass.cpp:29
+
+    static_assert(std::is_same_v<T, decltype(std::midpoint(T(), T()))>, "");
+    static_assert(                  noexcept(std::midpoint(T(), T())), "");
----------------
nit: any reason not to use`ASSERT_SAME_TYPE`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59099/new/

https://reviews.llvm.org/D59099





More information about the libcxx-commits mailing list